Skip to content

Comments

Follow symlinks when copying files into containers#1235

Merged
cristianrgreco merged 1 commit intomainfrom
codex/issue-713-follow-symlinks
Feb 17, 2026
Merged

Follow symlinks when copying files into containers#1235
cristianrgreco merged 1 commit intomainfrom
codex/issue-713-follow-symlinks

Conversation

@cristianrgreco
Copy link
Collaborator

Summary of changes

  • Follow symbolic links when copying files via withCopyFilesToContainer before container start.
  • Follow symbolic links when copying files via copyFilesToContainer on started containers.
  • Add integration coverage for both paths to assert observable behavior in-container: copied file content is present and target is not a symlink.
  • Extract reusable symlink test fixture setup/cleanup into test helper utilities.
  • Document that file copy follows symbolic links.

Verification commands run

  • npm run format
  • npm run lint
  • npm test -- packages/testcontainers/src/generic-container/generic-container.test.ts -t "copy file to container|copy file to started container|follow symlink"

Test results summary

  • Targeted generic-container file-copy tests passed, including the two new symlink scenarios.

Closes #713

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 5ea8610
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69947bfba082900008ce9c79
😎 Deploy Preview https://deploy-preview-1235--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Feb 17, 2026
@cristianrgreco cristianrgreco merged commit 6274827 into main Feb 17, 2026
340 checks passed
@cristianrgreco cristianrgreco deleted the codex/issue-713-follow-symlinks branch February 17, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withCopyFilesToContainer should follow symlinks by default

1 participant